process: delay creation of process.env until after bootstrap/node.js #26515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that no code is allowed to access process.env during the execution of bootstrap/node.js.
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Mar 8, 2019
BridgeAR
approved these changes
Mar 8, 2019
jasnell
approved these changes
Mar 8, 2019
BridgeAR
added
the
author ready
|
|
|
Landed in ee2d263 |
joyeecheung
added a commit
that referenced
this pull request
Mar 11, 2019
Make sure that no code is allowed to access process.env during the execution of bootstrap/node.js. PR-URL: #26515 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
|
This does not land cleanly on v11. It seems to rely on other commits that should be backported first. Please open a manual backport for it or change the labels accordingly. |
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
Make sure that no code is allowed to access process.env during the execution of bootstrap/node.js. PR-URL: #26515 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that no code is allowed to access process.env during
the execution of bootstrap/node.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes